Skip to content

Traces sample rate default change #4335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 29, 2025
Merged

Traces sample rate default change #4335

merged 3 commits into from
Apr 29, 2025

Conversation

antonpirker
Copy link
Member

Revert changing the default of traces_sample_rate done in #4240

@antonpirker antonpirker changed the base branch from master to potel-base April 28, 2025 14:41
@codecov Codecov
Copy link

codecov bot commented Apr 28, 2025 •
edited
Loading

❌ 6 Tests Failed:

Tests completed Failed Passed Skipped
23924 6 23918 5421
View the top 3 failed test(s) by shortest run time 
tests.integrations.redis.cluster.test_redis_cluster test_rediscluster_pipeline[False-expected_first_ten0]
Stack Traces | 0.095s run time 
.../redis/cluster/test_redis_cluster.py:121: in test_rediscluster_pipeline
    pipeline = rc.pipeline()
.../redis/cluster/test_redis_cluster.py:16: in <lambda>
    redis.RedisCluster.pipeline = lambda *_, **__: pipeline_cls(None, None)
.tox/py3.12-redis-latest/lib/python3.12.../site-packages/redis/utils.py:188: in wrapper
    return func(*args, **kwargs)
.tox/py3.12-redis-latest/lib/python3.12.../site-packages/redis/cluster.py:2125: in __init__
    retries=self.cluster_error_retry_attempts,
E   AttributeError: 'ClusterPipeline' object has no attribute 'cluster_error_retry_attempts'
tests.integrations.redis.cluster.test_redis_cluster test_rediscluster_pipeline[True-expected_first_ten1]
Stack Traces | 0.096s run time 
.../redis/cluster/test_redis_cluster.py:121: in test_rediscluster_pipeline
    pipeline = rc.pipeline()
.../redis/cluster/test_redis_cluster.py:16: in <lambda>
    redis.RedisCluster.pipeline = lambda *_, **__: pipeline_cls(None, None)
.tox/py3.12-redis-latest/lib/python3.12.../site-packages/redis/utils.py:188: in wrapper
    return func(*args, **kwargs)
.tox/py3.12-redis-latest/lib/python3.12.../site-packages/redis/cluster.py:2125: in __init__
    retries=self.cluster_error_retry_attempts,
E   AttributeError: 'ClusterPipeline' object has no attribute 'cluster_error_retry_attempts'
tests.integrations.redis.cluster.test_redis_cluster test_rediscluster_span_origin
Stack Traces | 0.097s run time 
.../redis/cluster/test_redis_cluster.py:160: in test_rediscluster_span_origin
    pipeline = rc.pipeline(transaction=False)
.../redis/cluster/test_redis_cluster.py:16: in <lambda>
    redis.RedisCluster.pipeline = lambda *_, **__: pipeline_cls(None, None)
.tox/py3.12-redis-latest/lib/python3.12.../site-packages/redis/utils.py:188: in wrapper
    return func(*args, **kwargs)
.tox/py3.12-redis-latest/lib/python3.12.../site-packages/redis/cluster.py:2125: in __init__
    retries=self.cluster_error_retry_attempts,
E   AttributeError: 'ClusterPipeline' object has no attribute 'cluster_error_retry_attempts'

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@antonpirker antonpirker marked this pull request as ready for review April 28, 2025 15:10
@antonpirker antonpirker requested a review from a team as a code owner April 28, 2025 15:10
@antonpirker antonpirker merged commit 35fab6b into potel-base Apr 29, 2025
129 checks passed
@antonpirker antonpirker deleted the antonpirker/potel/revert-traces-sample-rate-default-change branch April 29, 2025 08:34
@antonpirker antonpirker mentioned this pull request Apr 29, 2025
Draft
@antonpirker antonpirker restored the antonpirker/potel/revert-traces-sample-rate-default-change branch May 5, 2025 12:29
@antonpirker antonpirker mentioned this pull request May 5, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sl0thentr0py sl0thentr0py sl0thentr0py approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@antonpirker @sl0thentr0py